TST: GH30999 Add match=msg to test_nat_comparisons_invalid #38564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
the
Missing-data
|
thanks @moink |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request xref #30999 to remove bare pytest.raises. It doesn't close that issue as I have only addressed one file: pandas/tests/scalar/test_nat.py . In that file there was only one test that had a bare pytest.raises and I added a message to the two instances of pytest.raises in that test. It required modifications to the test parameters in order to populate the message.
I did not add a whatsnew entry since it's only a tiny change to one test. Let me know if I should add one (and I am a bit unclear on how, i.e. what version this would end up in).
This is my first ever pull request to an open source project. I am expecting that I will have to make changes before it's accepted; thanks for your patience.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff